Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: Update default container config #13612

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 16, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: configs: Update default container config
Additional Description:

This updates the defaut container config to:

  • use the envoyproxy.io website as the default upstream proxy
  • listen for admin interface on 0.0.0.0 address

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13497
[Optional Deprecated:]

phlax added 2 commits October 16, 2020 20:03
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title configs: Update default container config [WIP] configs: Update default container config Oct 16, 2020
@phlax phlax marked this pull request as draft October 16, 2020 20:13
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

configs/envoyproxy_io_proxy.yaml Outdated Show resolved Hide resolved
@htuch htuch self-assigned this Oct 16, 2020
@phlax phlax marked this pull request as ready for review October 17, 2020 10:22
@phlax phlax changed the title [WIP] configs: Update default container config configs: Update default container config Oct 17, 2020
@phlax phlax force-pushed the configs-container-configs branch 2 times, most recently from 45db76d to 1216055 Compare October 22, 2020 13:33
@phlax
Copy link
Member Author

phlax commented Oct 22, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines.
Cannot retry non-completed check: envoy-presubmit (check linux_x64 api), please wait.

🐱

Caused by: a #13612 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the configs-container-configs branch from 1216055 to 547e216 Compare October 22, 2020 16:11
@phlax
Copy link
Member Author

phlax commented Oct 22, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines.

🐱

Caused by: a #13612 (comment) was created by @phlax.

see: more, trace.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 3c24562 into envoyproxy:master Oct 22, 2020
chradcliffe pushed a commit to chradcliffe/envoy that referenced this pull request Oct 23, 2020
This updates the defaut container config to:
- use the envoyproxy.io website as the default upstream proxy
- listen for admin interface on 0.0.0.0 address

Fixes envoyproxy#13497

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default configs in Docker images dont work very well out of the box
2 participants