Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/build: Add .dockerignore to limit build context #13618

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 17, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: ci/build: Add .dockerignore to limit build context
Additional Description:

This is a workaround fix for #13613 that limits the context that is sent to the Docker daemon when building

It doesnt make much difference to CI (windows build may be a little quicker) but it does improve experience for end users building locally

by default it excludes everything and then lists paths to include. I have added the local/ dir as a path to allow adding local artifacts into a build - i will document this as part of #13490 (or once this has landed)

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13613
[Optional Deprecated:]

@phlax phlax force-pushed the ci-add-dockerignore branch from a950e98 to e29661d Compare October 17, 2020 13:43
@phlax phlax changed the title ci/build: Add .dockerignore to limit build context [WIP] ci/build: Add .dockerignore to limit build context Oct 17, 2020
@phlax phlax marked this pull request as draft October 17, 2020 17:03
@phlax phlax force-pushed the ci-add-dockerignore branch 3 times, most recently from 185b647 to 1d54d25 Compare October 18, 2020 08:21
@phlax phlax force-pushed the ci-add-dockerignore branch from 35ecde9 to 9628eb7 Compare October 18, 2020 09:59
@phlax phlax changed the title [WIP] ci/build: Add .dockerignore to limit build context build: Add .dockerignore to limit build context Oct 18, 2020
@phlax phlax changed the title build: Add .dockerignore to limit build context ci/build: Add .dockerignore to limit build context Oct 18, 2020
@phlax phlax marked this pull request as ready for review October 18, 2020 10:05
@phlax phlax force-pushed the ci-add-dockerignore branch from 9628eb7 to 6aa1d91 Compare October 21, 2020 14:58
@phlax
Copy link
Member Author

phlax commented Oct 22, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13618 (comment) was created by @phlax.

see: more, trace.

@phlax phlax force-pushed the ci-add-dockerignore branch from 6aa1d91 to 257031f Compare October 22, 2020 13:32
@phlax
Copy link
Member Author

phlax commented Oct 23, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines.
Cannot retry non-completed check: envoy-presubmit, please wait.

🐱

Caused by: a #13618 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
@mattklein123 mattklein123 merged commit 202ac51 into envoyproxy:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont build Docker images with the repo as the context
3 participants