Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] docs: Add developers section to docs #13745

Closed
wants to merge 10 commits into from

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 24, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Add developers section to docs
Additional Description:

This is currently very WIP, and the focus is mostly on figuring out a rough structure for dev docs atm...

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13431
[Optional Deprecated:]

phlax added 8 commits October 24, 2020 11:36
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Oct 24, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13745 (comment) was created by @phlax.

see: more, trace.

@phlax phlax marked this pull request as draft October 25, 2020 09:58
phlax added 2 commits October 25, 2020 10:18
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Oct 25, 2020

@mattklein123 this is a really first pass attempt to thrash out a rough structure for dev docs - with one eye on what im aware of in terms of existing docs, and the other on how we might best structure this from pov of developers getting started

rendered docs (no copy etc atm) are here:

https://storage.googleapis.com/envoy-pr/13745/docs/dev/index.html

@mattklein123 mattklein123 self-assigned this Oct 27, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is awesome. Let me know how you want to proceed on this one.

/wait

Comment on lines +27 to +33
Developer documentation
-----------------------

.. toctree::
:maxdepth: 2

dev/index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way on this ultimately, but my suggestion from before was to make this hidden, and then just have a direct link to the dev docs root from our README. I think this would avoid polluting the end-user docs with dev docs while still allowing cross linking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least with the redirects plugin in we have now this is not possible, and wouldnt be without quite a lot of hackery

i searched again today to see if there was anything like a "split-tree" rendering in sphinx and turned up nothing

i think to go the way you suggest is fighting the system too much, altho i guess its theoretically possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it's not a big deal. Maybe just set max depth to 1 or something so not much shows up in the main index?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sgtm

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@mattklein123 mattklein123 removed the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 8, 2021
@phlax
Copy link
Member Author

phlax commented Jan 13, 2021

bump

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jan 13, 2021
Base automatically changed from master to main January 15, 2021 23:01
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 22, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR has not been touched recently waiting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Move developer docs to main docs (or at least to an .rst tree)
2 participants