-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] docs: Add developers section to docs #13745
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
/retest |
Retrying Azure Pipelines. |
@mattklein123 this is a really first pass attempt to thrash out a rough structure for dev docs - with one eye on what im aware of in terms of existing docs, and the other on how we might best structure this from pov of developers getting started rendered docs (no copy etc atm) are here: https://storage.googleapis.com/envoy-pr/13745/docs/dev/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is awesome. Let me know how you want to proceed on this one.
/wait
Developer documentation | ||
----------------------- | ||
|
||
.. toctree:: | ||
:maxdepth: 2 | ||
|
||
dev/index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go either way on this ultimately, but my suggestion from before was to make this hidden, and then just have a direct link to the dev docs root from our README. I think this would avoid polluting the end-user docs with dev docs while still allowing cross linking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least with the redirects plugin in we have now this is not possible, and wouldnt be without quite a lot of hackery
i searched again today to see if there was anything like a "split-tree" rendering in sphinx and turned up nothing
i think to go the way you suggest is fighting the system too much, altho i guess its theoretically possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK it's not a big deal. Maybe just set max depth to 1 or something so not much shows up in the main index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, sgtm
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
bump |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: docs: Add developers section to docs
Additional Description:
This is currently very WIP, and the focus is mostly on figuring out a rough structure for dev docs atm...
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13431
[Optional Deprecated:]