Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update quick-start #13754

Merged
merged 26 commits into from
Oct 27, 2020
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 26, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Update quick-start
Additional Description:

was " to add dynamic configuration information" but that has been kicked to later PR

and some other cleanups of the quick-start page

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax marked this pull request as draft October 26, 2020 10:16
phlax added 4 commits October 26, 2020 10:41
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Oct 26, 2020

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added 8 commits October 26, 2020 14:06
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added 6 commits October 26, 2020 17:33
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] docs: Update quick-start to add dynamic configuration information docs: Update quick-start to add dynamic configuration information Oct 26, 2020
@phlax phlax marked this pull request as ready for review October 26, 2020 19:30
@mattklein123 mattklein123 self-assigned this Oct 27, 2020
@phlax
Copy link
Member Author

phlax commented Oct 27, 2020

@mattklein123 i think the grammar typo above is the last change i wanted to make

ill wait a little while, and if you have no nits/changes ill fix it...

phlax added 2 commits October 27, 2020 16:10
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very cool. Dropping some small comments. We can do them in follow ups if you want.

/wait-any

docs/root/start/quick-start.rst Outdated Show resolved Hide resolved
docs/root/start/_include/envoy-dynamic-demo.yaml Outdated Show resolved Hide resolved
docs/root/start/_include/envoy-dynamic-demo.yaml Outdated Show resolved Hide resolved
docs/root/start/quick-start.rst Show resolved Hide resolved
@phlax phlax marked this pull request as draft October 27, 2020 16:27
@phlax phlax changed the title docs: Update quick-start to add dynamic configuration information [WIP] docs: Update quick-start to add dynamic configuration information Oct 27, 2020
phlax added 2 commits October 27, 2020 16:32
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] docs: Update quick-start to add dynamic configuration information [WIP] docs: Update quick-start Oct 27, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
@mattklein123
Copy link
Member

LMK when this is no longer WIP/draft.

/wait

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] docs: Update quick-start docs: Update quick-start Oct 27, 2020
@phlax phlax marked this pull request as ready for review October 27, 2020 18:05
@phlax
Copy link
Member Author

phlax commented Oct 27, 2020

ping @mattklein123 - should be ready for review again

@mattklein123 mattklein123 merged commit 499df78 into envoyproxy:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants