Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: fixing a bug with IPv6 hosts #13798

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

alyssawilk
Copy link
Contributor

Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Risk Level: low
Testing: new unit, integration tests
Docs Changes: n/a
Release Notes: inline

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk added the backport/review Request to backport to stable releases label Oct 28, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@yanavlasov
Copy link
Contributor

Build set-up failure for OS/X, merging.

@yanavlasov yanavlasov merged commit e3c097d into envoyproxy:master Oct 29, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 30, 2020
* master: (83 commits)
  tls: Typesafe tls slots (envoyproxy#13789)
  docs(example): Correct URL for caching example page (envoyproxy#13810)
  [fuzz] Made health check fuzz more efficient (envoyproxy#13747)
  rtds: properly scope rtds stats (envoyproxy#13764)
  http: fixing a bug with IPv6 hosts (envoyproxy#13798)
  connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772)
  network: adding some accessors for ALPN work. (envoyproxy#13785)
  docs: added a step about how to handle platform specific extensions (envoyproxy#13759)
  Fix identation in ip transparency code snippet (envoyproxy#13743)
  wasm: enable WAVM's stack unwinding feature (envoyproxy#13792)
  log: set route name for direct response (envoyproxy#13683)
  Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763)
  [Windows] Update windows dev docs (envoyproxy#13741)
  cel: patch thread safety issue (envoyproxy#13739)
  Windows: Fix ssl_socket_test (envoyproxy#13264)
  apple dns: add fake api test suite (envoyproxy#13780)
  overload: scale selected timers in response to load (envoyproxy#13475)
  examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746)
  Removed exception in getResponseStatus() (envoyproxy#13314)
  network: add timeout for transport connect (envoyproxy#13610)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@PiotrSikora
Copy link
Contributor

@cpakulski anything with backport/review label needs to be evaluated for backporting and if approved, that label should be changed to backport/approved and PRs sent to stable releases.

@cpakulski cpakulski added backport/approved Approved backports to stable releases and removed backport/review Request to backport to stable releases labels Nov 13, 2020
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Dec 2, 2020
Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: Shikugawa <rei@tetrate.io>
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Dec 4, 2020
Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: Shikugawa <rei@tetrate.io>
antoniovicente pushed a commit that referenced this pull request Jan 8, 2021
Signed-off-by: alyssawilk <alyssar@chromium.org>
Signed-off-by: Shikugawa <rei@tetrate.io>
antoniovicente pushed a commit that referenced this pull request Jan 8, 2021
Signed-off-by: alyssawilk <alyssar@chromium.org>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
@alyssawilk alyssawilk deleted the connect_ipv6 branch June 10, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/approved Approved backports to stable releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants