Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add VRP runtime validation to verify_examples. #14099

Merged
merged 3 commits into from
Nov 20, 2020
Merged

examples: add VRP runtime validation to verify_examples. #14099

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e02c2d
examples: add VRP runtime validation to verify_examples.
htuch Nov 18, 2020
fcc550c
wip
htuch Nov 19, 2020
7b891d5
Use existing curl extra args support.
htuch Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/verify-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ MANUAL="${MANUAL:-}"
NAME="${NAME:-}"
PATHS="${PATHS:-.}"
UPARGS="${UPARGS:-}"
EXTRA_CURL_ARGS="${EXTRA_CURL_ARGS:-}"


run_log () {
Expand Down Expand Up @@ -72,7 +73,7 @@ cleanup () {

_curl () {
local arg curl_command
curl_command=(curl -s)
curl_command=(curl -s "${EXTRA_CURL_ARGS[@]}")
htuch marked this conversation as resolved.
Show resolved Hide resolved
if [[ ! "$*" =~ "-X" ]]; then
curl_command+=(-X GET)
fi
Expand Down
1 change: 1 addition & 0 deletions examples/vrp-litmus/Dockerfile-vrp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
FROM envoyproxy/envoy-google-vrp-dev:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about just moving VRP into examples? It is technically an example of a somewhat secure configuration? Would that be simpler and more self contained?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this would integrate with the DockerHub push flow. Examples run after the base images that get pushed to DockerHub are built in CI. Do we push any other examples to DockerHub?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah dunno, just a thought. NBD.

3 changes: 3 additions & 0 deletions examples/vrp-litmus/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Simple litmus test to verify the VRP image in CI. For more details on VRP,
please see
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/google_vrp.
17 changes: 17 additions & 0 deletions examples/vrp-litmus/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
version: "3.7"
services:

vrp:
build:
context: .
dockerfile: Dockerfile-vrp
environment:
ENVOY_EDGE_EXTRA_ARGS: ""
ENVOY_ORIGIN_EXTRA_ARGS: ""
networks:
- envoymesh
ports:
- "10000:10000"

networks:
envoymesh: {}
14 changes: 14 additions & 0 deletions examples/vrp-litmus/verify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/bin/bash -e

export NAME=vrp-litmus
export DELAY=10
export EXTRA_CURL_ARGS=(-k)

# shellcheck source=examples/verify-common.sh
. "$(dirname "${BASH_SOURCE[0]}")/../verify-common.sh"


run_log "Test proxy"
responds_with \
normal \
https://localhost:10000/content