Undeprecate use_original_dst #14387
Closed
Undeprecate use_original_dst #14387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Barrella <tabarr@google.com>
|
LGTM, but I'm confused why CI checks are stuck and RepoKitteh hasn't flagged this as an API review. |
|
@itayd do you know why RK didn't run here? |
|
/rk-ping |
|
pong |
|
i think that the ci didn't run as expected is telling - github probably suffered some transient failure at least with this pr. can you close and recreate this pr? |
|
Sure, #14397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Undeprecate use_original_dst
Signed-off-by: Taylor Barrella tabarr@google.com
Additional Description: See #5355 (comment) and above for context
Risk Level: Low
Testing: Listener unit tests, grep
Docs Changes: Generated documentation for the proto field
Release Notes:
#5355