event: Extract DispatcherBase interface #14446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
akonradi
previously approved these changes
Dec 16, 2020
akonradi
reviewed
Dec 16, 2020
include/envoy/event/dispatcher.h
Outdated
| @@ -52,12 +52,67 @@ using PostCb = std::function<void()>; | |||
| using PostCbSharedPtr = std::shared_ptr<PostCb>; | |||
|
|
|||
| /** | |||
| * Abstract event dispatching loop. | |||
| * Minimal interface to the disptching loop used to create low-level primitives. See Dispatcher | |||
There was a problem hiding this comment.
nit: sp on dispatching is causing your format failure
|
This makes sense to me but this is small enough that do we want to just do this change in another change that actually needs it? Up to you all. /wait |
Signed-off-by: Antonio Vicente <avd@google.com>
@akonradi Thoughts? Do you want to include this in a PR that adds a way to create scaled timers via the dispatcher? |
mattklein123
approved these changes
Dec 17, 2020
|
Given that this is already approved, I say let's get it in now. No need to make the next PR bigger. |
|
Thanks Matt. |
itamarkam
pushed a commit
to itamarkam/envoy
that referenced
this pull request
Dec 21, 2020
Signed-off-by: Antonio Vicente <avd@google.com>
itamarkam
pushed a commit
to itamarkam/envoy
that referenced
this pull request
Jan 25, 2021
Signed-off-by: Antonio Vicente <avd@google.com>
itamarkam
added a commit
to itamarkam/envoy
that referenced
this pull request
Jan 25, 2021
This reverts commit e73281d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
event: Extract DispatcherBase interface
This new interface allows us to more safely build primitives like ScaledTimers which are themselves built on top of low-level
event loop primitives like Timers which are themselves created via the dispatcher interface.
Additional Description:
Risk Level: n/a interface only change
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Issue #14401