tools: fix build breakages under //tools and add //tools build to CI

[antoniovicente]

Commit Message: tools: fix build breakages under //tools and add //tools build to CI
Additional Description:
Risk Level: n/a, tools change
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

[antoniovicente]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

[foreseeable]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

The headersplit_test need the libClang module to build, and libClang require the libclang.so from Clang.
But libclang.so is not contained in the Bazel sandbox environment, so I used --spawn_strategy=local to disable Bazel sandboxing for //tools/envoy_headersplit:headersplit_test as a workaround.

[antoniovicente]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

The headersplit_test need the libClang module to build, and libClang require the libclang.so from Clang.
But libclang.so is not contained in the Bazel sandbox environment, so I used --spawn_strategy=local to disable Bazel sandboxing for //tools/envoy_headersplit:headersplit_test as a workaround.

ok, that's helpful. I see that the test is explicitly run in do_ci.sh with those extra flags. I think that making this test "manual" is the right work around for bazel test //tools/...

[antoniovicente]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

The headersplit_test need the libClang module to build, and libClang require the libclang.so from Clang.
But libclang.so is not contained in the Bazel sandbox environment, so I used --spawn_strategy=local to disable Bazel sandboxing for //tools/envoy_headersplit:headersplit_test as a workaround.

ok, that's helpful. I see that the test is explicitly run in do_ci.sh with those extra flags. I think that making this test "manual" is the right work around for bazel test //tools/...

I'm not sure what I'm missing, but the test fails for me when run as:
$ bazel test tools/envoy_headersplit:headersplit_test --spawn_strategy=local

[antoniovicente]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

The headersplit_test need the libClang module to build, and libClang require the libclang.so from Clang.
But libclang.so is not contained in the Bazel sandbox environment, so I used --spawn_strategy=local to disable Bazel sandboxing for //tools/envoy_headersplit:headersplit_test as a workaround.

ok, that's helpful. I see that the test is explicitly run in do_ci.sh with those extra flags. I think that making this test "manual" is the right work around for bazel test //tools/...

I'm not sure what I'm missing, but the test fails for me when run as:
$ bazel test tools/envoy_headersplit:headersplit_test --spawn_strategy=local

I think that the test calls in do_ci.sh for //tools/envoy_headersplit tests are missing the "test" verb. I would think that the resulting bazel calls to fail, not sure why it is not failing.

envoy/ci/do_ci.sh

Line 269 in 09134ff

bazel_with_collection //tools/envoy_headersplit:headersplit_test --spawn_strategy=local

[foreseeable]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

The headersplit_test need the libClang module to build, and libClang require the libclang.so from Clang.
But libclang.so is not contained in the Bazel sandbox environment, so I used --spawn_strategy=local to disable Bazel sandboxing for //tools/envoy_headersplit:headersplit_test as a workaround.

ok, that's helpful. I see that the test is explicitly run in do_ci.sh with those extra flags. I think that making this test "manual" is the right work around for bazel test //tools/...

I'm not sure what I'm missing, but the test fails for me when run as:
$ bazel test tools/envoy_headersplit:headersplit_test --spawn_strategy=local

I think that the test calls in do_ci.sh for //tools/envoy_headersplit tests are missing the "test" verb. I would think that the resulting bazel calls to fail, not sure why it is not failing.

envoy/ci/do_ci.sh

Line 269 in 09134ff

bazel_with_collection //tools/envoy_headersplit:headersplit_test --spawn_strategy=local

Thanks for pointing out this. It seems I made a mistake and i am going to fix it.

[antoniovicente]

Posted https://github.com/envoyproxy/envoy/pull/12150/files#r554287142 about the //tools/envoy_headersplit:headersplit_test failure. I'm tempted to mark the test 'manual' and file an issue about it being broken since I have no idea how to fix it.

The headersplit_test need the libClang module to build, and libClang require the libclang.so from Clang.
But libclang.so is not contained in the Bazel sandbox environment, so I used --spawn_strategy=local to disable Bazel sandboxing for //tools/envoy_headersplit:headersplit_test as a workaround.

ok, that's helpful. I see that the test is explicitly run in do_ci.sh with those extra flags. I think that making this test "manual" is the right work around for bazel test //tools/...

I'm not sure what I'm missing, but the test fails for me when run as:
$ bazel test tools/envoy_headersplit:headersplit_test --spawn_strategy=local

I think that the test calls in do_ci.sh for //tools/envoy_headersplit tests are missing the "test" verb. I would think that the resulting bazel calls to fail, not sure why it is not failing.

envoy/ci/do_ci.sh

Line 269 in 09134ff

bazel_with_collection //tools/envoy_headersplit:headersplit_test --spawn_strategy=local

Thanks for pointing out this. It seems I made a mistake and i am going to fix it.

I made the change as part of this PR, waiting for CI to tell me what happens.

[htuch]

The only test that fails is compile_time_options. Arguably this should not apply to //tools/.... This gets back to my earlier point about restricting this to a single build, which I think bazel.debug would make sense for. If you do that, you should be able to build cleanly.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!