http: refactor out stream rate limiter to common

[nitgoy]

Commit Message: Refactor out stream rate limiter class from the fault filter to common. This enables the code to be shared with other extensions such as the bandwidth limit filter. The change is just simple refactoring and shouldn't affect/be visible to users.
Additional Description:
Risk Level: Low
Testing: All unit tests passed.
Docs Changes: None

[repokitteh-read-only]

Hi @nitgoy, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #14828 was opened by nitgoy.

see: more, trace.

[yanavlasov]

Thanks for the PR. Looks like you need to run ./tools/code_format/check_format.py fix to fix code forma errors.

[nitgoy]

Thanks for the PR. Looks like you need to run ./tools/code_format/check_format.py fix to fix code forma errors.

I'm having some permission issues running that script today. Working on fixing them.

[nitgoy]

Thanks for the PR. Looks like you need to run ./tools/code_format/check_format.py fix to fix code forma errors.

@yanavlasov Addressed the format issue. Any idea about the current presubmit (examples) failure? It doesn't seem related to my changes. Looks like disk ran out of space or something.

[ggreenway]

@nitgoy a fix for the verify-examples CI job is in main now; merge main into this PR and it should pass.

[yanavlasov]

Thanks for refactoring this. Would it be possible to extract unit tests for the StreamRateLimiter class from the test/extensions/filters/http/fault/fault_filter_test.cc ? It may need some refactoring as well. Otherwise we now have some common class that is tested by an extension.

[yanavlasov]

/wait

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[nitgoy]

Hi @yanavlasov. sorry for the long wait but I just got the chance to finalize the changes. Can you help to reopen the PR? I'm not able to see that option on my side.