Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump protobuf from 3.15.7 to 3.15.8 in /examples/grpc-bridge/client #15899

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 9, 2021

Bumps protobuf from 3.15.7 to 3.15.8.

Release notes

Sourced from protobuf's releases.

Protocol Buffers v3.15.8

Ruby

  • Fixed memory leak of Ruby arena objects (#8461)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 9, 2021
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 9, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #15899 was opened by dependabot[bot].

see: more, trace.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@htuch
Copy link
Member

htuch commented Apr 11, 2021

@phlax can you look into the clang-tidy issue? Seems to be exiting on no diff (I don't understand why it would be an issue here vs. other dep bump issues..)

@htuch htuch self-assigned this Apr 11, 2021
@phlax
Copy link
Member

phlax commented Apr 12, 2021

can you look into the clang-tidy issue?

ive raised the clang_tidy issue here #15700 - its not immediately clear to me why this is failing - but it fails consistently for dependabot - something to do with dependabot creating an envoy branch i think, rather than a dependabot branch

@phlax
Copy link
Member

phlax commented Apr 12, 2021

...rather than a dependabot branch

does this happen if you create a PR from an envoy branch manually ?

@htuch
Copy link
Member

htuch commented Apr 12, 2021

@lizan can you help?

@lizan
Copy link
Member

lizan commented Apr 12, 2021

#15700 (comment)

@phlax
Copy link
Member

phlax commented Apr 20, 2021

aggregated in #16079

@phlax phlax closed this Apr 20, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 20, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/examples/grpc-bridge/client/protobuf-3.15.8 branch April 20, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants