grpc_json_transcoder: Switch tests to compare JSON objects #16085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teju Nareddy <nareddyt@google.com>
qiwzhang
approved these changes
Apr 20, 2021
yanavlasov
approved these changes
Apr 20, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…y#16085) Signed-off-by: Teju Nareddy <nareddyt@google.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
grpc_json_transcoder: Switch tests to compare JSON objects
Additional Description:
Risk Level: None
Testing: Unit tests for new utility function.
Docs Changes: None
Release Notes: None
Platform Specific Features: None
Signed-off-by: Teju Nareddy nareddyt@google.com