http local_ratelimit: add request_headers_to_add option #16178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 26, 2021 10:37
Signed-off-by: William Fu <wfu@pinterest.com>
Signed-off-by: William Fu <wfu@pinterest.com>
Signed-off-by: William Fu <wfu@pinterest.com>
Signed-off-by: William Fu <wfu@pinterest.com>
htuch
reviewed
Apr 26, 2021
| // Specifies a list of HTTP headers that should be added to each request that | ||
| // has been rate limited and is also forwarded upstream. This can only occur when the | ||
| // filter is enabled but not enforced. | ||
| repeated config.core.v3.HeaderValueOption request_headers_to_add = 10 |
There was a problem hiding this comment.
This probably needs a different name, maybe request_headers_to_add_when_not_enforced?
…orced Signed-off-by: William Fu <wfu@pinterest.com>
yanavlasov
approved these changes
Apr 28, 2021
|
Code LGTM. Waiting for API approval. |
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…6178) Introduce the ability to add request headers to forwarded upstream requests when the local HTTP rate limit filter determines (through its configured ruleset) that a request should be rate limited, but is not hard enforcing the incoming traffic. Additional Description: This is useful when a backend service should take customized action when a particular traffic volume is reached, rather than forcing request shedding by the proxy. Risk Level: Low, adding a new feature Testing: Modified unit tests Docs Changes: Updated associated doc Signed-off-by: William Fu <wfu@pinterest.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…6178) Introduce the ability to add request headers to forwarded upstream requests when the local HTTP rate limit filter determines (through its configured ruleset) that a request should be rate limited, but is not hard enforcing the incoming traffic. Additional Description: This is useful when a backend service should take customized action when a particular traffic volume is reached, rather than forcing request shedding by the proxy. Risk Level: Low, adding a new feature Testing: Modified unit tests Docs Changes: Updated associated doc Signed-off-by: William Fu <wfu@pinterest.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Introduce the ability to add request headers to forwarded upstream requests when the local HTTP rate limit filter determines (through its configured ruleset) that a request should be rate limited, but is not hard enforcing the incoming traffic.
Additional Description:
This is useful when a backend service should take customized action when a particular traffic volume is reached, rather than forcing request shedding by the proxy.
Risk Level: Low, adding a new feature
Testing: Modified unit tests
Docs Changes: Updated associated doc
Release Notes:
Platform Specific Features: