Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: removing envoy.reloadable_features.http_match_on_all_headers #16195

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

alyssawilk
Copy link
Contributor

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Part of #16018

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@@ -30,6 +30,7 @@ Removed Config or Runtime

* http: removed `envoy.reloadable_features.allow_500_after_100` runtime guard and the legacy code path.
* http: removed `envoy.reloadable_features.hcm_stream_error_on_invalid_message` for disabling closing HTTP/1.1 connections on error. Connection-closing can still be disabled by setting the HTTP/1 configuration :ref:`override_stream_error_on_invalid_http_message <envoy_v3_api_field_config.core.v3.Http1ProtocolOptions.override_stream_error_on_invalid_http_message>`.
* http: removed `envoy.reloadable_features.http_match_on_all_headers` runtime guard and legacy code paths.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need to rebase - inline literals now need to be double backticked (which is the semantically correct way in rst)

im in the process of updating the guidance (and improving the rendering)...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - thanks for the heads up!

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@yanavlasov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alyssawilk alyssawilk merged commit 152762a into envoyproxy:main Apr 28, 2021
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
…nvoyproxy#16195)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Part of envoyproxy#16018

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Gokul Nair <gnair@twitter.com>
@alyssawilk alyssawilk deleted the http_match_on_all_headers branch August 18, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants