-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[safe_memcpy_test] Explicit type for arguments of the vector constructor #16549
Conversation
Signed-off-by: rialg <grial@google.com>
Please, @jmarantz and @antoniovicente , could you add yourselves as reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/retest |
Retrying Azure Pipelines: |
Change looks good, but it would be good to hear from @Wyverald on wherever or not this fixes the issue he saw in the bazel build and how to repo that breakage. |
Thanks for the PR. Unfortunately there isn't an easy way to do a test CI run on a PR (unless we turn the pipeline on for all future Envoy PRs -- which we could certainly do). Is there a way to push this PR to a branch in the main Envoy repo (envoyproxy/envoy)? That would give us a way to test beforehand if this fixes it. |
The presubmit pipeline failed due to low code coverage in the tests.
Should we lower this target to match the current value? |
I think once #16570 merges you should be good? @alyssawilk has another PR also which might just improve the coverage. |
go ahead an 'merge main' and this coverage issue should be resolved. |
Signed-off-by: rialg <grial@google.com>
ok, we'll give it another shot if this change isn't sufficient. |
…or (envoyproxy#16549) Signed-off-by: rialg <grial@google.com>
Signed-off-by: rialg grial@google.com
Commit Message: Explicit type for arguments of the vector constructor
Additional Description: Issue #16542
Risk Level: N/A