Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: adjusting coverage #16570

Merged
merged 1 commit into from
May 19, 2021
Merged

quic: adjusting coverage #16570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/per_file_coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ declare -a KNOWN_LOW_COVERAGE=(
"source/common/singleton:95.1"
"source/common/thread:0.0" # Death tests don't report LCOV
"source/common/matcher:93.3"
"source/common/quic:88.4"
"source/common/quic:87.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target may be flaky.

Code coverage for source/common/quic is lower than limit of 87.8 (87.7)

https://dev.azure.com/cncf/envoy/_build/results?buildId=76243&view=logs&j=5035ce29-be3c-5fcf-dc50-abb6a265f8b1&t=548c3e59-0417-5971-4f1b-f8545005c291&l=17979

"source/common/tracing:95.7"
"source/common/watchdog:42.9" # Death tests don't report LCOV
"source/exe:94.3"
Expand Down