Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protos: Remove squash from api:v2_protos #16910

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 9, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: protos: Remove squash from api:v2_protos
Additional Description:

this is a follow up to #16336 as in a subsequent PR proto_format was trying to remove this

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP/TESTING] protos: Remove squash from api:v2_protos protos: Remove squash from api:v2_protos Jun 9, 2021
@phlax phlax requested a review from htuch June 9, 2021 21:09
@phlax phlax marked this pull request as ready for review June 9, 2021 21:09
@phlax
Copy link
Member Author

phlax commented Jun 9, 2021

@htuch i separated this out from #16903 as i wanted to check its safe to do this - that PR was trying to remove this and also the same for other protos that are being removed

@phlax
Copy link
Member Author

phlax commented Jun 9, 2021

...also im concerned that something similar might start happening on other peoples PRs - ie trying to remove this proto

@htuch
Copy link
Member

htuch commented Jun 9, 2021

Why wasn't this caught in CI on #16336?

@phlax
Copy link
Member Author

phlax commented Jun 10, 2021

Why wasn't this caught in CI on #16336?

i was rather hoping you would know the answer to that

proto_sync.py etc is a bit of a mystery to me - mostly i have been using trial and error to make it happy as im not entirely clear as to what its doing

@phlax
Copy link
Member Author

phlax commented Jun 10, 2021

@htuch i tried making some arbitrary changes to proto files to see if i could trigger the problem (#16923 ) - it did not

its a mystery to me why removal is being enforced in #16903

either way - i think we want to do this - no ?

@htuch
Copy link
Member

htuch commented Jun 11, 2021

Yep, sure. I think once v2 is gone we get rid of proto_sync.py anyway.

@htuch htuch merged commit eb291ce into envoyproxy:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants