-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: Make use of new incremental pip installer #18026
Conversation
e29183f
to
eff3c18
Compare
eff3c18
to
85bcf4a
Compare
892a26f
to
c3f37a8
Compare
8( this seems to be blocked by bazelbuild/rules_python#527 |
/wait |
2cebac2
to
9b936dc
Compare
unblocked by using upstream main/HEAD |
67d1b77
to
c20579f
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
c20579f
to
5ee6d61
Compare
/assign-from @envoyproxy/dependency-shepherds |
@envoyproxy/dependency-shepherds assignee is @mattklein123 |
following up offline conversation with @htuch - this currently removes the requirements.txt from the kafka extension we may, for purposes of code ownership, want to keep some requirements.txt files separate - like, eg, the kafka one mho is that we (want to) maintain the deps across the repo, and that doesnt tend to be so related to codeownership, more dependency shepherding, so for the sake of making the latter easier, the less dependabotted files the better |
/lgtm deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I do remain a little uneasy at the lack of versioning in requirements.in
. I'm going to go with what you said in your other review and accept that we probably don't care most of the time and when we do, we have the option to pin.
Signed-off-by: Ryan Northey <ryan@synca.io>
@mattklein123 i had to readd the requirements file for code_format |
yep, we can not sure if you saw my other comment about cross-platform compilation of the lock file atm pip-compile doesnt do the right thing on this, so if you want eg a package only on windows, you need to add it without any predicates, and then add in bazel so its only loaded in win |
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: bazel: Make use of new incremental pip installer
Additional Description:
this rationalizes the pip dependencies down to ~1 requirements file (there are a few others left for non bazel requirements atm)
also removes dep comments, as previously requested by @moderation
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]