Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: remove an assert #18201

Merged
merged 2 commits into from
Sep 22, 2021
Merged

network: remove an assert #18201

merged 2 commits into from
Sep 22, 2021

Conversation

alyssawilk
Copy link
Contributor

#16122 added asserts to utilities to make sure they were called from the correct thread.
Over on the Envoy mobile side when we do QUIC we're doing it from the main thread, and failing some of the assert checks.
I think the right thing to do here is just remove the assert

This is the only use of isWorkerThread() so I'm inclined to just remove it.
cc @goaway

Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk changed the title Assert network: remove an assert Sep 21, 2021
@goaway
Copy link
Contributor

goaway commented Sep 21, 2021

Thanks @alyssawilk! /cc @colibie

@alyssawilk
Copy link
Contributor Author

/retest now CI is unbroken

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18201 (comment) was created by @alyssawilk.

see: more, trace.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay red.

@alyssawilk alyssawilk merged commit 956d834 into envoyproxy:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants