Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quiche: updating deps #18272

Merged
merged 2 commits into from
Sep 28, 2021
Merged

quiche: updating deps #18272

merged 2 commits into from
Sep 28, 2021

Conversation

alyssawilk
Copy link
Contributor

Signed-off-by: Alyssa Wilk alyssar@chromium.org

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@alyssawilk
quiche: updating deps
26a66a3 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18272 was opened by alyssawilk.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 27, 2021
@alyssawilk
test fix
9ad4bd2 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 27, 2021
@alyssawilk
Copy link
Contributor Author

FYI I needed the test change as the QUIC test got way flakier failing a client side assert that the handshake is finalized before we tried port migration. Not sure why, but waiting for handshake completion seemed reasonable so I went with that.

@RenjieTang
Copy link
Contributor

FYI I needed the test change as the QUIC test got way flakier failing a client side assert that the handshake is finalized before we tried port migration. Not sure why, but waiting for handshake completion seemed reasonable so I went with that.

Drive-by: I noticed the same thing when I write tests for my port migration PR. And yeah the tests should wait for handshake confirmed to performa port migration anyway.

@danzh2010
Copy link
Contributor

FYI I needed the test change as the QUIC test got way flakier failing a client side assert that the handshake is finalized before we tried port migration. Not sure why, but waiting for handshake completion seemed reasonable so I went with that.

Drive-by: I noticed the same thing when I write tests for my port migration PR. And yeah the tests should wait for handshake confirmed to performa port migration anyway.

Probably a recent QUICHE update flips connection migration related flags that disallows peer address change before handshake gets confirmed.

danzh2010
danzh2010 approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@danzh2010 danzh2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM along aside mac CI failure.

@mattklein123 mattklein123 merged commit fdda682 into envoyproxy:main Sep 28, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 29, 2021
@mpuncel
Merge branch 'main' into mpuncel/hc-after-sds-init-manager
66373d1 
* main: (114 commits)
  kafka: add header support to mesh-filter (envoyproxy#18248)
  rbac: add support for upstream ip policy. (envoyproxy#17645)
  SIPProxy BUGFIX UT failure for fastbuild/debug (envoyproxy#18303)
  quic: updating goaway code (envoyproxy#18291)
  various tiny fixes (envoyproxy#18287)
  dns cache: remove assert at this layer (envoyproxy#18301)
  [ext_authz]: ext_authz filter unit test that use real threading (envoyproxy#17742)
  signal action: fully disable sigaltstack on Apple (envoyproxy#18299)
  Add missing dependencies (envoyproxy#18297)
  ext_proc: Pass stream_info to gRPC streams (envoyproxy#18190)
  use clang 12 (envoyproxy#18220)
  Update PR template to include the "Fixes commit" message when reverting or fixing bad commits (envoyproxy#18298)
  [test] Fixing integration test to cleanup cleanly (envoyproxy#18293)
  test: moving grpc bridge tests out of core directory (envoyproxy#18227)
  runtime: disable deprecated extensions names by default (envoyproxy#18239)
  quiche: updating deps (envoyproxy#18272)
  sip_proxy: SIP protocol support in envoy (envoyproxy#18039)
  http: add core retry policy to route retry policy conversion utility (envoyproxy#17803)
  build: updating stale visibility (envoyproxy#18278)
  alternate_protocols_cache: Impose a max size limit on the alternate protocols cache (envoyproxy#18258)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@alyssawilk alyssawilk deleted the quic_import branch August 4, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danzh2010 danzh2010 danzh2010 approved these changes

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

@danzh2010 danzh2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alyssawilk @moderation @RenjieTang @danzh2010 @mattklein123