Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Request copy assignment operator. #18865

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

KBaichoo
Copy link
Contributor

@KBaichoo KBaichoo commented Nov 2, 2021

Signed-off-by: Kevin Baichoo kbaichoo@google.com

Commit Message: The copy assignment operator is being invoked for SocketOptionName implicitly. Explicitly request it.
Additional Description:
Risk Level: N/A
Testing: NA
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

It seems to be breaking for Clang 14. See:

Step #3 - "compile-afl-address-x86_64": �[1m./envoy/network/socket.h:26:3: �[0m�[0;1;31merror: �[0m�[1mdefinition of implicit copy assignment operator for 'SocketOptionName' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]�[0m
Step #3 - "compile-afl-address-x86_64":   SocketOptionName(const SocketOptionName&) = default;
Step #3 - "compile-afl-address-x86_64": �[0;1;32m  ^
Step #3 - "compile-afl-address-x86_64": �[0m�[1msource/common/network/socket_option_impl.cc:52:14: �[0m�[0;1;30mnote: �[0min implicit copy assignment operator for 'Envoy::Network::SocketOptionName' first required here�[0m

Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
@KBaichoo
Copy link
Contributor Author

KBaichoo commented Nov 2, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18865 (comment) was created by @KBaichoo.

see: more, trace.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ggreenway ggreenway merged commit ca13cce into envoyproxy:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants