Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: disable C++ tests. #21483

Closed
wants to merge 2 commits into from
Closed

wasm: disable C++ tests. #21483

wants to merge 2 commits into from

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
wasm: disable C++ tests.
a5e34a5 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #21483 was opened by PiotrSikora.

see: more, trace.

@PiotrSikora PiotrSikora marked this pull request as ready for review May 27, 2022 17:43
@PiotrSikora PiotrSikora requested a review from lizan as a code owner May 27, 2022 17:43
@htuch htuch mentioned this pull request May 27, 2022
Closed
htuch
htuch previously approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21485

@PiotrSikora
review: add NPM to spelling dictionary.
bdd3de5 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@htuch
Copy link
Member

htuch commented May 27, 2022

#21487 was merged instead.

@htuch htuch closed this May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch left review comments

@lizan lizan Awaiting requested review from lizan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiotrSikora @htuch