Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: workaround invalid nonnull warning in v8 #23765

Merged
merged 1 commit into from
Nov 1, 2022
Merged

bazel: workaround invalid nonnull warning in v8 #23765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions bazel/v8.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ index 4e89f90e7e..3fcb38b3f3 100644

# Default setting for v8_enable_pointer_compression.
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
index e957c0fad3..5870a914aa 100644
index e957c0fad3..a6de50e6ab 100644
--- a/bazel/defs.bzl
+++ b/bazel/defs.bzl
@@ -116,6 +116,7 @@ def _default_args():
Expand All @@ -42,7 +42,15 @@ index e957c0fad3..5870a914aa 100644
"-std=c++17",
],
"@v8//bazel/config:is_gcc": [
@@ -151,6 +152,23 @@ def _default_args():
@@ -131,6 +132,7 @@ def _default_args():
"-Wno-redundant-move",
"-Wno-return-type",
"-Wno-stringop-overflow",
+ "-Wno-nonnull",
# Use GNU dialect, because GCC doesn't allow using
# ##__VA_ARGS__ when in standards-conforming mode.
"-std=gnu++17",
@@ -151,6 +153,23 @@ def _default_args():
"-fno-integrated-as",
],
"//conditions:default": [],
Expand Down