ci: Replace python go proto script with ci target #27675
Conversation
phlax
force-pushed
the
bazel-go-protos
branch
7 times, most recently
from
4cc036a
to
fcc3df2
Compare
phlax
force-pushed
the
bazel-go-protos
branch
5 times, most recently
from
7043021
to
c0affda
Compare
|
not sure why ci is failing. I tested it locally and got it working, then pushed and it failed due to RBE, so reproed locally with RBE and fixed, but its still failing 8/ |
phlax
force-pushed
the
bazel-go-protos
branch
4 times, most recently
from
2b44f4c
to
d26d0af
Compare
|
debugging CI fail further locally - afaict the issue is because the api is being built previously, and as a result its using the cache and not downloading the go files - it may be related to bazelbuild/bazel#13882 - i think it probably passed previously due to building the go files first adding |
phlax
changed the title
|
this needs envoyproxy/go-control-plane#701 in place before it can land im also wondering whether we should replace the python script with a stub to raise an error with a "Please use ci/do_ci.sh api.go instead" message |
|
/wait |
|
updated the script to message and also added an |
|
@alecholmez there is a bit of a chicken/egg situation here - we kinda need to simultaneously update downstream i guess its possible we could do it in steps, ill raise a PR to update and use the new target now |
Signed-off-by: Ryan Northey <ryan@synca.io>
apologies for confusion - thinking further - downstream has its own implementation so this just needs to land first |
|
All good! I'll standby for merging in go-control-plane |
| ]) > 0 | ||
| def main(): | ||
| # TODO(phlax): remove this 12/23 | ||
| sys.stderr.write("This script has been removed, please use `ci/do_ci.sh api.go` instead\n") |
There was a problem hiding this comment.
Should we just delete this script? Less cruft n the tools folder
There was a problem hiding this comment.
im a little concerned that others may be using it so would rather add this ~deprecation/removal notice for now
phlax
changed the title
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
This replaces the current python script to build the go protos with a bash ci target, and removes the git logic which has been shifted downstream
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]