build: adding an disable_exceptions (which does not yet work) #27811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
changed the title
alyssawilk
requested review from
RyanTheOptimist,
abeyad,
yanavlasov,
mattklein123 and
htuch
as code owners
|
raven I seem to remember the parity of build options sometimes biting y'all. This is a no-op by default which I think is what you need but throwing it your way to confirm :-) |
|
I think this is unproblematic, because it's both defaulting to disabled and also behaving disabled if the config value is entirely unset (which is where we were bitten before). Thanks for thinking of me. :) |
|
/wait I think format is broken =P |
|
/wait again |
alyssawilk
commented
Jun 6, 2023
| @@ -105,41 +105,41 @@ InstanceImpl::InstanceImpl( | |||
| router_context_(store.symbolTable()), process_context_(std::move(process_context)), | |||
| hooks_(hooks), quic_stat_names_(store.symbolTable()), server_contexts_(*this), | |||
| enable_reuse_port_default_(true), stats_flush_in_progress_(false) { | |||
| std::function set_up_logger = [&] { | |||
There was a problem hiding this comment.
fix format and clang could not handle nested macros so I had to avoid it with std::functions :-/
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
RyanTheOptimist
approved these changes
Jun 6, 2023
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
…roxy#27811) The new build option simply compiles out all try/catch code, while leaving in the exceptions. This can not yet be successfully used as it turns up fno-exceptions which chokes on throw statements. This is by design as if we compiled out throw as well, config failures would be fatal instead of gracefully handled. Risk Level: low Testing: manual testing Docs Changes: n/a Release Notes: n/a Part of envoyproxy#27412 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: asheryer <asheryer@amazon.com>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
…roxy#27811) The new build option simply compiles out all try/catch code, while leaving in the exceptions. This can not yet be successfully used as it turns up fno-exceptions which chokes on throw statements. This is by design as if we compiled out throw as well, config failures would be fatal instead of gracefully handled. Risk Level: low Testing: manual testing Docs Changes: n/a Release Notes: n/a Part of envoyproxy#27412 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new build option simply compiles out all try/catch code, while leaving in the exceptions. This can not yet be successfully used as it turns up fno-exceptions which chokes on throw statements. This is by design as if we compiled out throw as well, config failures would be fatal instead of gracefully handled.
Risk Level: low
Testing: manual testing
Docs Changes: n/a
Release Notes: n/a
Part of #27412