-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING/WIP] ci/coverage: Test proxy-wasm-cpp-sdk PR#157 #29118
[TESTING/WIP] ci/coverage: Test proxy-wasm-cpp-sdk PR#157 #29118
Conversation
proxy-wasm/proxy-wasm-cpp-sdk#157 Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Hi @martijneken, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken i think this arm fail should actually error our CI is naively retrying the fetch regardless of what is actually failing |
Thanks for noticing that! May be a patch issue. I'm first looking at the zlib/cmake build error caused by the emsdk update, debugging on this thread: proxy-wasm/proxy-wasm-cpp-sdk#157 (comment) |
marking this as draft CI is failing due to date mismatches: DependencyChecker ERROR ERRORS Summary [release_dates]:
--------------------------------------------------------------------------------
Mismatch: emsdk 2022-03-09 != 2023-07-28
Mismatch: proxy_wasm_cpp_sdk 2022-03-15 != 2023-08-17 should be easy to fix - just update the relevant entries in ill be happy to review if you make further progress /wait |
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Test proxy-wasm/proxy-wasm-cpp-sdk#157
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]