Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING/WIP] ci/coverage: Test proxy-wasm-cpp-sdk PR#157 #29118

Closed

Conversation

martijneken
Copy link

Test proxy-wasm/proxy-wasm-cpp-sdk#157

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

Hi @martijneken, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #29118 was opened by martijneken.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Aug 17, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #29118 was opened by martijneken.

see: more, trace.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@phlax
Copy link
Member

phlax commented Aug 18, 2023

@martijneken i think this arm fail should actually error

https://dev.azure.com/cncf/envoy/_build/results?buildId=146455&view=logs&j=73e537b6-cc68-5fb1-7c2c-4ed0653c6430&t=0f59e640-fc23-554d-8732-e8a44a166327&l=98

our CI is naively retrying the fetch regardless of what is actually failing

@mattklein123 mattklein123 assigned phlax and unassigned mattklein123 Aug 21, 2023
@martijneken
Copy link
Author

@martijneken i think this arm fail should actually error

Thanks for noticing that! May be a patch issue. I'm first looking at the zlib/cmake build error caused by the emsdk update, debugging on this thread: proxy-wasm/proxy-wasm-cpp-sdk#157 (comment)

@phlax
Copy link
Member

phlax commented Aug 28, 2023

marking this as draft

CI is failing due to date mismatches:

DependencyChecker ERROR ERRORS Summary [release_dates]:
--------------------------------------------------------------------------------
Mismatch: emsdk 2022-03-09 != 2023-07-28
Mismatch: proxy_wasm_cpp_sdk 2022-03-15 != 2023-08-17

should be easy to fix - just update the relevant entries in bazel/repository_locations.bzl

ill be happy to review if you make further progress

/wait

@phlax phlax marked this pull request as draft August 28, 2023 16:43
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Oct 6, 2023
@martijneken martijneken deleted the test-proxywasmcppsdk-pr157 branch February 16, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants