-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access log formatter: use new formatter context rather than multiple parameters (3/3) #30758
access log formatter: use new formatter context rather than multiple parameters (3/3) #30758
Conversation
…parameters (1/3) Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
…ccess-log-formatter
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
…parameters (2/3) Signed-off-by: wbpcode <wbphub@live.com>
…parameters (3/3) Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
…ccess-log-formatter-part3
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
…ccess-log-formatter-part3 Signed-off-by: wbpcode <wbphub@live.com>
Related to #13085 |
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one suggestion.
Signed-off-by: wbpcode <wbphub@live.com>
weird coverage result. the result tell wasm coverage rate is lower than the limit but from my local test result, it should be covered all. |
Signed-off-by: wbpcode <wbphub@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for doing this.
Commit Message: access log formatter: use new formatter context rather than multiple parameters (3/3)
Additional Description:
Continuous work of #30757. Waiting #30757 to be landed first.
The PR update the log
Instance
interface to be a specialization ofInstanceBase
with context type HttpFormatterContext.And by this way, the
log()
method of Filter is updated to take a HttpFormatterContext reference as parameter.This PR also do similar update to the
AccessLogInstanceFactory
and make it a specialization of AccessLogInstanceFactoryBase.By this way, log instances of different modules will share the same code base.
Note, to ensure the backwards compatibility, the extension category of log instance should be kept as envoy.access_loggers.
This is the last PR of this big refactoring. After landed this PR, we will finally completely migrate our formatter/logger to use the context based interface.
This will bring two obvious benefits:
Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.