-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext_proc: send attributes #31090
ext_proc: send attributes #31090
Conversation
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
@@ -221,7 +221,8 @@ void Filter::onDestroy() { | |||
} | |||
|
|||
FilterHeadersStatus Filter::onHeaders(ProcessorState& state, | |||
Http::RequestOrResponseHeaderMap& headers, bool end_stream) { | |||
Http::RequestOrResponseHeaderMap& headers, bool end_stream, | |||
ProtobufWkt::Struct* proto) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should proto be passed by reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use nullptr
to indicate that attributes are not configured. This is on Line 243
/lgtm |
please specify a single label can be specified |
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
It appears that the |
You're right, I'll look into this |
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for your patience! Nice work
defer to @yanavlasov for final review and merge. PTAL, Thanks |
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
@yanavlasov a friendly ping for final review and merge when you get a chance? Thx! |
Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
* ext_proc: send attributes (envoyproxy#31090) Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io> * ext_proc: send and receive dynamic metadata (envoyproxy#30747) Introduce the ability to send dynamic metadata in the External Processing Request. Also implements the API for returning dynamic metadata as part of the External Processing Response. --------- Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io> * ext_proc: revise service api for attributes (envoyproxy#32176) --------- Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io> --------- Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Rework of #30781 which was reverted in #31017 due to ASAN fuzzer issues
The ASAN fuzzer issues are unrelated to the net-new code here and will affect any code that calls CEL
Parse
.The main differences between this and the original PR:
expr
object from whichParsedExpr
are built per ext_proc: send attributes #30781 (comment)request_attributes
andresponse_attributes
fields on non-ASAN fuzzing due to unrelated issue with ASAN fuzzing in CEL parsing per Revert ext_proc: send attributes #30781 #31017 (comment)Commit Message:
Introduce the ability to send attributes in the External Processing Request
Additional Description:
Risk Level: Low
Testing: Integration tests for request/response attributes
Release Notes: N/A
Platform Specific Features: CEL parsing will not work on Windows