envoy: move listener manager code back under source #31129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
listener_move
branch
7 times, most recently
from
19001e0 to
6f96797
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
listener_move
branch
from
6f96797 to
ae0aeaf
Compare
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
alyssawilk
requested review from
mattklein123,
RyanTheOptimist,
abeyad,
kyessenov,
lizan,
ggreenway,
soulxu,
adisuissa and
KBaichoo
as code owners
ggreenway
reviewed
Dec 4, 2023
| @@ -59,6 +59,7 @@ declare -a KNOWN_LOW_COVERAGE=( | |||
| "source/extensions/wasm_runtime/wasmtime:0.0" # Not enabled in coverage build | |||
| "source/extensions/wasm_runtime/wavm:0.0" # Not enabled in coverage build | |||
| "source/extensions/watchdog:83.3" # Death tests within extensions | |||
| "source/extensions/listener_managers:70.5" | |||
There was a problem hiding this comment.
Wow, this is quite low. It looks like the only change in that directory is a path in a #include. Do you understand why the test coverage is so low?
There was a problem hiding this comment.
this directory covered the highly tested TCP code and the not highly tested validation manager code.
There was a problem hiding this comment.
facepalm Thanks!
Coverage LGTM
alyssawilk
force-pushed
the
listener_move
branch
from
c7758a2 to
df7889f
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ggreenway
requested changes
Dec 5, 2023
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ggreenway
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Part of #31113