ci/permissions: Restrict permissions for remaining workflows #31603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mmorel-35 - not sure if we need to add some back in jobs |
|
What do you mean by "back in jobs" ? |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
scorecard-token-permissions
branch
from
5024ef9
to
dac49b0
Compare
provide job-level permissions |
|
OK, Usually, I'm using https://app.stepsecurity.io/secureworkflow to help defining the right configuration :
Is this also what you did ? |
no - i generally define them by hand (after checking the docs and the action) in this case im responding to a scorecard alert that these wfs dont have global token restrictions |
phlax
commented
Jan 3, 2024
| @@ -1,5 +1,8 @@ | |||
| name: 'Sync downstream' | |||
|
|
|||
| permissions: | |||
| contents: read | |||
There was a problem hiding this comment.
this one is good - it uses appauth
|
afaict - this is what is required for codeql permissions:
contents: read
security-events: write
pull-requests: read |
|
which i think is already covered - except perhaps read perms in a private repo - ill update |
Signed-off-by: Ryan Northey <ryan@synca.io>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]