Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile/ci: Fix iOS build failures #31756

Merged
merged 1 commit into from
Jan 11, 2024

mobile/ci: Fix iOS_build failures

cb433bb
Select commit
Loading
Failed to load commit list.
Merged

mobile/ci: Fix iOS build failures #31756

mobile/ci: Fix iOS_build failures
cb433bb
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Windows skipped Jan 10, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/31756/main@cb433bb)

fredyw @fredyw cb433bb #31756 merge main@7bd0c0f

mobile/ci: Fix iOS build failures

The error:

ERROR: /Users/runner/work/envoy/envoy/mobile/WORKSPACE:98:18: fetching android_sdk_repository rule //external:androidsdk: Android SDK api level 30 was requested but it is not installed in the Android SDK at /Users/runner/Library/Android/sdk. The api levels found were [34, 33, 32, 31]. Please choose an available api level or install api level 30 from the Android SDK Manager.

This PR is a workaround to install Android SDK 30 even though it's not used for building iOS apps, that's because mobile/WORKSPACE expects the Android SDK 30 to be available and GitHub Runner image no longer includes Android SDK 30. See actions/runner-images#8952. Passing --android in the ./ci/mac_ci_setup.sh will install the Android SDK 30.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref 2b9532c39fae4490f121e073b62898f82278017e
sha cb433bb
pr 31756
base-sha 7bd0c0f
actor fredyw @fredyw
message mobile/ci: Fix iOS build failures...
started 1704928772.907209
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 29
patch 0
dev true