Revert "mobile/ci: Fix iOS build failures (#31756)" #32558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f37ef3f. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
abeyad
approved these changes
Feb 23, 2024
ohadvano
pushed a commit
to ohadvano/envoy
that referenced
this pull request
Feb 25, 2024
…roxy#32558) * Revert "mobile/ci: Fix iOS build failures (envoyproxy#31756)" This reverts commit f37ef3f. and removes unsed code path Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default github action runners have ANDROID_HOME and ANDROID_NDK_HOME set automatically. Because of this our bazel logic requires android to be installed. For jobs that don't request android explicitly we now unset this to save that install CI time. This also changes the CI setup to actively source the mac_ci_setup script since previously those env vars would be ignored, since github actions sources the text listed there, but not each line
This reverts commit f37ef3f.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com