Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Clean up Java and Kotlin code #32773

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Mar 7, 2024

Simple clean up to make the Java and Kotlin code more idiomatic.

Risk Level: low (cosmetic changes only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <fredyw@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32773 was opened by fredyw.

see: more, trace.

@fredyw
Copy link
Member Author

fredyw commented Mar 7, 2024

/retest

1 similar comment
@fredyw
Copy link
Member Author

fredyw commented Mar 7, 2024

/retest

@fredyw fredyw marked this pull request as ready for review March 7, 2024 18:39
@fredyw
Copy link
Member Author

fredyw commented Mar 7, 2024

/assign @abeyad

Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these code quality improvements!

@abeyad abeyad merged commit 459f719 into envoyproxy:main Mar 7, 2024
36 checks passed
@fredyw fredyw deleted the mobile_cleanup branch March 7, 2024 18:57
mattjo added a commit to mattjo/envoy that referenced this pull request Mar 7, 2024
* origin:
  mobile: Clean up Java and Kotlin code (envoyproxy#32773)
  [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754)
  oauth2: support disabling redirects for AJAX requests (envoyproxy#32655)
  http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751)
  envoy: reverting unnecessary exception E-M macros (envoyproxy#32745)
  dfp: reverting 31433 (envoyproxy#32743)
  opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681)
  mobile: Java code cleanup (envoyproxy#32747)
  mobile: fix quic_test_server_test (envoyproxy#32755)
  Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants