mobile: Remove HTTP server code from TestJni #33169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredyw
force-pushed
the
jni_http_proxy_test
branch
from
4b113d9 to
88680e6
Compare
|
/retest |
fredyw
changed the title
|
/retest |
fredyw
force-pushed
the
jni_http_proxy_test
branch
from
88680e6 to
2320b6e
Compare
|
/retest |
fredyw
force-pushed
the
jni_http_proxy_test
branch
4 times, most recently
from
8328bf7 to
07b299e
Compare
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
|
/assign @abeyad |
Signed-off-by: Fredy Wijaya <fredyw@google.com>
fredyw
force-pushed
the
jni_http_proxy_test
branch
from
07b299e to
a591f42
Compare
abeyad
reviewed
Mar 28, 2024
| @@ -0,0 +1,38 @@ | |||
| package io.envoyproxy.envoymobile.engine.testing; | |||
There was a problem hiding this comment.
wasn't this part of the previous PR? I think tip-of-tree needs to be sync'ed with this branch?
There was a problem hiding this comment.
This is for the proxy test server.
Signed-off-by: Fredy Wijaya <fredyw@google.com>
Signed-off-by: Fredy Wijaya <fredyw@google.com>
abeyad
approved these changes
Mar 28, 2024
abeyad
added a commit
to abeyad/envoy
that referenced
this pull request
Mar 30, 2024
The test failed when adding the native Assertion filter, with an error from loadFromYaml: INVALID_ARGUMENT: could not find @type 'type.googleapis.com/envoymobile.extensions.filters.http.assertion.Assertion After running git bisect, it turns out the bad commit came from envoyproxy#33169. That PR introduces HttpTestServer to the SendDataTest.kt, which causes the required proto types to not get loaded. In this commit, the test is fixed by using a TestRemoteResponse filter, similar to the other Kotlin tests (e.g. SendTrailersTest). However, we need to figure out why the config filter protos aren't loading when creating the HttpTestServer. Signed-off-by: Ali Beyad <abeyad@google.com>
abeyad
added a commit
that referenced
this pull request
Apr 1, 2024
The test failed when adding the native Assertion filter, with an error from loadFromYaml: INVALID_ARGUMENT: could not find @type 'type.googleapis.com/envoymobile.extensions.filters.http.assertion.Assertion After running git bisect, it turns out the bad commit came from #33169. That PR introduces HttpTestServer to the SendDataTest.kt, which causes the required proto types to not get loaded. In this commit, the test is fixed by using a TestRemoteResponse filter, similar to the other Kotlin tests (e.g. SendTrailersTest). However, we need to figure out why the config filter protos aren't loading when creating the HttpTestServer. Signed-off-by: Ali Beyad <abeyad@google.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
This PR removes the HTTP server code from TestJni. The tests have been updated to use either HttpTestServer or HttpProxyTestServer. This PR also moves test_server_interface.[h|cc] into its own build target. Risk Level: low (tests only) Testing: unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: mobile Signed-off-by: Fredy Wijaya <fredyw@google.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
The test failed when adding the native Assertion filter, with an error from loadFromYaml: INVALID_ARGUMENT: could not find @type 'type.googleapis.com/envoymobile.extensions.filters.http.assertion.Assertion After running git bisect, it turns out the bad commit came from envoyproxy#33169. That PR introduces HttpTestServer to the SendDataTest.kt, which causes the required proto types to not get loaded. In this commit, the test is fixed by using a TestRemoteResponse filter, similar to the other Kotlin tests (e.g. SendTrailersTest). However, we need to figure out why the config filter protos aren't loading when creating the HttpTestServer. Signed-off-by: Ali Beyad <abeyad@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the HTTP server code from
TestJni. The tests have been updated to use eitherHttpTestServerorHttpProxyTestServer.This PR also moves
test_server_interface.[h|cc]into its own build target.Risk Level: low (tests only)
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile