[bp/1.28] Fix build error with maxmind if http3 is disabled (#33638)
#33661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roxy#33638) `maxmind` is causing the build to not honor the flag `--//bazel:http3=False`: The define `ENVOY_ENABLE_QUIC` is still being passed to the compiler. This causes code that rely on the presence (or not) of that define to behave wrongly. I am not 100% sure of what causes it, but Bazel doc says 1) to not use `bind` and 2) that `bind` and `select` do not play well together: https://bazel.build/reference/be/workspace#bind By removing the `bind` and pointing directly to the actual dependency in `maxmind` BUILD file, we fix this issue. Backport of envoyproxy#33638 Signed-off-by: Jonh Wendell <jwendell@redhat.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
approved these changes
Apr 18, 2024
repokitteh-read-only
bot
removed
the
deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxmindis causing the build to not honor the flag--//bazel:http3=False: The defineENVOY_ENABLE_QUICis still being passed to the compiler. This causes code that rely on the presence (or not) of that define to behave wrongly.I am not 100% sure of what causes it, but Bazel doc says 1) to not use
bindand 2) thatbindandselectdo not play well together: https://bazel.build/reference/be/workspace#bindBy removing the
bindand pointing directly to the actual dependency inmaxmindBUILD file, we fix this issue.Backport of #33638