Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: removing whitespace from appended XFF headers #3587

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

alyssawilk
Copy link
Contributor

Risk Level: Low
Testing: updated unit tests
Docs Changes: n/a
Release Notes: inline

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@alyssawilk alyssawilk merged commit 4882bb5 into envoyproxy:master Jun 11, 2018
danielhochman added a commit that referenced this pull request Jun 12, 2018
This reverts commit 4882bb5.

Signed-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>
mattklein123 pushed a commit that referenced this pull request Jun 12, 2018
…3609)

This reverts commit 4882bb5.

Signed-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Jul 10, 2018
…nvoyproxy#3587)" (envoyproxy#3609)"

This reverts commit 75ca181 with minor
docs edits.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants