Revert "config: removing deprecated bind_to_port (#5288)" #5344
Conversation
This reverts commit 36db776. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
This broke a few control planes (inc. Istio). |
|
@PiotrSikora when will Istio update? We should time box this. |
|
@mattklein123 also breaks other internal deps. I will followup on this today. |
|
@mattklein123 realistically? Late Q1. Ideally, before 1.9.0 is released, but I'm not sure if we can commit to that right now. |
OK |
|
@mattklein123 Thanks! Much appreciated. |
|
@mattklein123 the bindToPort is essential to almost everyone using virtual listeners and a single original dst listener. A single listener with filter chains will end up breaking long lived connections (db, grpc streams, etc.). I dont know why this was deprecated back in 2017, without having any alternative way of providing the same functionality (there was no incremental LDS nor filter chain discovery back then). I had argued earlier with @htuch to put this back into the main API instead of keeping it deprecated. Anyway, once we have an alternative like filterChain discovery or whatever, this bindToPort feature can enter the standard envoy deprecation cycle. The deprecation time frame would then allow us to support both older and newer proxies in Istio and migrate them. |
|
@dio @PiotrSikora Could you please add version tags to the commits? v0.6.4 and v0.6.5? |
@GregHanson huh? I don't follow. |
|
@PiotrSikora those fields are still removed in version 0.6.5 and 0.6.4: |
…nvoyproxy#5344) This reverts commit 36db776. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This reverts commit 36db776.
Signed-off-by: Piotr Sikora piotrsikora@google.com