upstream/extension: pass degraded load to plugins #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin Changes the interface of the retry priority plugin and updates the previous_priorities plugin to account for degraded hosts. The plugin will ignore both healthy and degraded hosts for an attempted priority, to retain the idea that we're excluding the entire priority after it's been attempted. Signed-off-by: Snow Pettersen <snowp@squareup.com>
Signed-off-by: Snow Pettersen <snowp@squareup.com>
Signed-off-by: Snow Pettersen <snowp@squareup.com>
Signed-off-by: Snow Pettersen <snowp@squareup.com>
zuercher
previously approved these changes
Jan 17, 2019
There was a problem hiding this comment.
This looks good to me, but I think it's worth having @mattklein123 take a look too.
snowp
force-pushed
the
degraded-retry-
branch
from
55242d4 to
3915ad5
Compare
|
Ignore the accidental force push :( |
mattklein123
approved these changes
Jan 18, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Changes the interface of the retry priority plugin and updates the previous_priorities plugin to account for degraded hosts. The plugin will ignore both healthy and degraded hosts for an attempted priority, to retain the idea that we're excluding the entire priority after it's been attempted. Signed-off-by: Snow Pettersen <snowp@squareup.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the interface of the retry priority plugin and updates the
previous_priorities plugin to account for degraded hosts.
The plugin will ignore both healthy and degraded hosts for an attempted
priority, to retain the idea that we're excluding the entire priority
after it's been attempted.
Signed-off-by: Snow Pettersen snowp@squareup.com
Risk Level: Medium, modifies existing plugin
Testing: UTs for healthy/degraded spillover behavior
Docs Changes: n/a
Release Notes: n/a
#5063