Drop Chromium UTF8 references we have not imported #9281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
🙀 Error while processing event: |
Chromium UTF8 logic is unneeded, as the missing templated result refers only to char const* (single-byte) characters at this time. This only trips up MSVC, since linux gcc seems to optimize it away. Indention is to avoid gratuitous diffs to origin source Signed-off-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: Yechiel Kalmenson <ykalmenson@pivotal.io>
|
/azp run envoy-windows |
|
Commenter does not have sufficient privileges for PR 9281 in repo envoyproxy/envoy |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This code was previously imported but there was some lingering
references left over relating to UTF8.
Chromium UTF8 logic is unneeded, as the missing templated result
refers only to char const* (single-byte) characters at this time.
This only trips up MSVC, since linux gcc seems to optimize it
away. Indention is to avoid gratuitous diffs to origin source
Risk Level: Low
Testing: Local compilation msvc and gcc
Docs Changes: N/A
Release Notes: N/A