move EnvoyProxy API to gateway.envoyproxy.io #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
added
area/api
Codecov Report
@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
+ Coverage 65.38% 65.42% +0.03%
==========================================
Files 90 90
Lines 13362 13362
==========================================
+ Hits 8737 8742 +5
+ Misses 4084 4080 -4
+ Partials 541 540 -1
|
|
will this be a break change for existing end users? especially upgrade? |
yeah this will be a breaking change, we had discussed this in the community meeting and looks like we reached some consensus on this |
* this keeps all CRDs/APIs under the gateway.envoyproxy.io group * this is a breaking change, that needs to be highlighted in the release notes. Undesirable but acceptable since these APIs are experimental (alpha) and are not yet stable Fixes: envoyproxy#809 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
requested review from
a team,
kflynn,
LanceEa and
chauhanshubham
and removed request for
a team
qicz
approved these changes
Oct 5, 2023
zirain
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this keeps all CRDs/APIs under the gateway.envoyproxy.io group
this is a breaking change, that needs to be highlighted in the release notes. Undesirable but acceptable since these APIs are experimental (alpha) and are not yet stable
Fixes: #809