chore: bump golang to 1.22 #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 64.88% 58.88% -6.00%
==========================================
Files 121 162 +41
Lines 21393 27083 +5690
==========================================
+ Hits 13880 15948 +2068
- Misses 6643 10182 +3539
- Partials 870 953 +83 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Mar 6, 2024
tools/src/helm-docs/go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/envoyproxy/gateway/tools/src/helm-docs | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
|
|
|||
| require github.com/norwoodj/helm-docs v1.12.0 | |||
|
@zirain crd-ref-docs cannot work in 1.22 .. |
can you raise this up on upstream? |
Closed
|
it's merged |
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
zirain
approved these changes
Apr 1, 2024
ShyunnY
pushed a commit
to ShyunnY/gateway
that referenced
this pull request
Apr 1, 2024
* chore: bump golang to 1.22 Signed-off-by: bitliu <bitliu@tencent.com> * fix: panic Signed-off-by: bitliu <bitliu@tencent.com> * bump crd-ref Signed-off-by: bitliu <bitliu@tencent.com> * make gen/testdata Signed-off-by: bitliu <bitliu@tencent.com> * fix docs failed Signed-off-by: bitliu <bitliu@tencent.com> * fix lint Signed-off-by: bitliu <bitliu@tencent.com> --------- Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Bump go version