Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Model OpenTelelemetry Sinks as a BackendRef #3067

Merged
merged 5 commits into from
Apr 2, 2024
Merged

api: Model OpenTelelemetry Sinks as a BackendRef #3067

merged 5 commits into from
Apr 2, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Mar 31, 2024

xref: #3041

@zirain zirain requested a review from a team as a code owner March 31, 2024 03:28
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 58.05%. Comparing base (69ffac8) to head (f1c34f7).
Report is 1 commits behind head on main.

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   58.05%   58.05%   -0.01%     
==========================================
  Files         165      165              
  Lines       27458    27475      +17     
==========================================
+ Hits        15942    15950       +8     
- Misses      10561    10571      +10     
+ Partials      955      954       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor Author

zirain commented Mar 31, 2024

wait #3068 merged to make this PR cleaner

@zirain
api: Model OpenTelelemetry Sinks as a BackendRef
594e5a9 
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg reviewed Apr 1, 2024
View reviewed changes
tools/make/golang.mk Outdated Show resolved Hide resolved
@zirain
update
04f3abc 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Merge branch 'main' into opentelemetry-backendref
eda1bf4
@zirain zirain requested a review from arkodg April 1, 2024 12:28
@zirain
fix gen
f1c34f7 
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

zhaohuabing
zhaohuabing approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@zhaohuabing zhaohuabing merged commit 06e4f39 into envoyproxy:main Apr 2, 2024
21 of 22 checks passed
@zirain zirain deleted the opentelemetry-backendref branch April 2, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zirain @zhaohuabing @arkodg