Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm-template should explicitly set ns #3070

Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix: helm-template should explicitly set ns #3070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 16 additions & 16 deletions test/helm/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: envoy-gateway
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand All @@ -17,7 +17,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: envoy-gateway-config
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand Down Expand Up @@ -163,14 +163,14 @@ roleRef:
subjects:
- kind: ServiceAccount
name: 'envoy-gateway'
namespace: 'default'
namespace: 'envoy-gateway-system'
---
# Source: gateway-helm/templates/infra-manager-rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: eg-gateway-helm-infra-manager
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand Down Expand Up @@ -212,7 +212,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: eg-gateway-helm-leader-election-role
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand Down Expand Up @@ -257,7 +257,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: eg-gateway-helm-infra-manager
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand All @@ -271,14 +271,14 @@ roleRef:
subjects:
- kind: ServiceAccount
name: 'envoy-gateway'
namespace: 'default'
namespace: 'envoy-gateway-system'
---
# Source: gateway-helm/templates/leader-election-rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: eg-gateway-helm-leader-election-rolebinding
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand All @@ -292,14 +292,14 @@ roleRef:
subjects:
- kind: ServiceAccount
name: 'envoy-gateway'
namespace: 'default'
namespace: 'envoy-gateway-system'
---
# Source: gateway-helm/templates/envoy-gateway-service.yaml
apiVersion: v1
kind: Service
metadata:
name: envoy-gateway
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
control-plane: envoy-gateway
helm.sh/chart: gateway-helm-v0.0.0-latest
Expand Down Expand Up @@ -328,7 +328,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: envoy-gateway
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
control-plane: envoy-gateway
helm.sh/chart: gateway-helm-v0.0.0-latest
Expand Down Expand Up @@ -421,7 +421,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: eg-gateway-helm-certgen
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand All @@ -436,7 +436,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: eg-gateway-helm-certgen
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand All @@ -460,7 +460,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: eg-gateway-helm-certgen
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand All @@ -476,14 +476,14 @@ roleRef:
subjects:
- kind: ServiceAccount
name: 'eg-gateway-helm-certgen'
namespace: 'default'
namespace: 'envoy-gateway-system'
---
# Source: gateway-helm/templates/certgen.yaml
apiVersion: batch/v1
kind: Job
metadata:
name: eg-gateway-helm-certgen
namespace: 'default'
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
app.kubernetes.io/name: gateway-helm
Expand Down
2 changes: 1 addition & 1 deletion tools/make/helm.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ helm-generate:

helm-template: ## Template envoy gateway helm chart.
@$(LOG_TARGET)
helm template eg charts/gateway-helm --set deployment.envoyGateway.image.tag=latest > ./test/helm/default.yaml
helm template eg charts/gateway-helm --set deployment.envoyGateway.image.tag=latest > ./test/helm/default.yaml --namespace=envoy-gateway-system