Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update codecov-action and remove workaround #3442

Merged
merged 2 commits into from
May 21, 2024

Conversation

shahar-h
Copy link
Contributor

What this PR does / why we need it:
Update codecov-action to v4.4.1, which includes a fix for codecov/codecov-action#1435 and remove ude_oidc condition.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner May 20, 2024 18:48
@arkodg
Copy link
Contributor

arkodg commented May 20, 2024

ha thanks for fixing this in upstream ❤️

@arkodg arkodg requested review from a team May 20, 2024 18:49
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (60888c0) to head (65ccc52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   67.37%   67.31%   -0.07%     
==========================================
  Files         166      166              
  Lines       19310    19310              
==========================================
- Hits        13010    12998      -12     
- Misses       5365     5374       +9     
- Partials      935      938       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahar-h
Copy link
Contributor Author

/retest

1 similar comment
@shahar-h
Copy link
Contributor Author

/retest

@zirain zirain merged commit b1f6e00 into envoyproxy:main May 21, 2024
23 checks passed
@shahar-h shahar-h deleted the update-codecov branch May 21, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants