-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: cookie based consistent hashing #3444
Conversation
have two opens questions here for @envoyproxy/gateway-maintainers and @envoyproxy/gateway-reviewers
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
- Coverage 67.45% 67.39% -0.06%
==========================================
Files 166 166
Lines 20058 20058
==========================================
- Hits 13531 13519 -12
- Misses 5548 5558 +10
- Partials 979 981 +2 ☔ View full report in Codecov by Sentry. |
One Cookie structure won't cause confusion to me. Two separate structures seem excessive since there is only one optional
Are there any "built-in" default Attributes? If not, the "Extra" is not needed. |
TTL field translates into Max-Age attribute |
Then "Extra" makes sense to me, though I don't have a strong preference for it. |
Relates to envoyproxy#2624 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Relates to #2624
Will use this underlying feature in Envoy https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-routeaction-hashpolicy-cookie