Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release note naming and generation #3795

Closed
wants to merge 1 commit into from

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jul 9, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Follow: #3794

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner July 9, 2024 07:30
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.04%. Comparing base (e63ffa0) to head (54730b2).

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.1    #3795      +/-   ##
================================================
+ Coverage         69.01%   69.04%   +0.03%     
================================================
  Files               176      176              
  Lines             21760    21760              
================================================
+ Hits              15017    15025       +8     
+ Misses             5662     5657       -5     
+ Partials           1081     1078       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor

zirain commented Jul 9, 2024

should we merge #3765 first?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Jul 9, 2024

should we merge #3765 first?

yes, but since the branch has been cut, if we need to get this in, we need to cp this into release branch too.

@Xunzhuo Xunzhuo closed this Jul 10, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants