-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support session persistence in HTTPRouteRule #3841
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3841 +/- ##
==========================================
- Coverage 67.61% 67.58% -0.03%
==========================================
Files 185 186 +1
Lines 22578 22689 +111
==========================================
+ Hits 15265 15335 +70
- Misses 6217 6251 +34
- Partials 1096 1103 +7 ☔ View full report in Codecov by Sentry. |
d33c8f3
to
53cb615
Compare
04752ea
to
0f45c69
Compare
Can we add an e2e test for this? |
d3527e8
to
9e8b85c
Compare
Done. Addressed the points from @zhaohuabing and added the e2e test. |
8936443
to
0eed511
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for picking this up!
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
45c2a89
to
baf0973
Compare
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
baf0973
to
c91cfb6
Compare
@arkodg Addressed your point + rebased for a conflict. |
/retest |
internal/xds/translator/testdata/in/xds-ir/http-route-session-persistence.yaml
Outdated
Show resolved
Hide resolved
internal/xds/translator/testdata/in/xds-ir/http-route-session-persistence.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
@zirain Updated based on your points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What type of PR is this?
What this PR does / why we need it:
support session persistence in HTTPRouteRule.
Which issue(s) this PR fixes:
Fixes #3315
Ref #2624 (comment)
GEP: https://gateway-api.sigs.k8s.io/geps/gep-1619/