Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move als test resources out of the base #3865

Closed
wants to merge 2 commits into from

Conversation

zhaohuabing
Copy link
Member

move als test resources out of the base to reduce resource consumption of e2e tests.

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner July 16, 2024 03:05
@zhaohuabing zhaohuabing marked this pull request as draft July 16, 2024 03:05
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.26%. Comparing base (45ac78b) to head (9cb2292).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3865   +/-   ##
=======================================
  Coverage   69.26%   69.26%           
=======================================
  Files         176      176           
  Lines       21740    21740           
=======================================
  Hits        15058    15058           
  Misses       5592     5592           
  Partials     1090     1090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing
Copy link
Member Author

zhaohuabing commented Jul 16, 2024

@zirain Need your help on this one :-)

Any idea why the tests are failing?

@zirain
Copy link
Contributor

zirain commented Jul 17, 2024

@zirain Need your help on this one :-)

Any idea why the tests are failing?

let me take a look

@zhaohuabing
Copy link
Member Author

Close this in favor of #3884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants