chore: remove BackendTrafficPolicyConnection #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4010 +/- ##
==========================================
+ Coverage 67.92% 67.96% +0.04%
==========================================
Files 187 187
Lines 23030 23030
==========================================
+ Hits 15642 15652 +10
+ Misses 6271 6266 -5
+ Partials 1117 1112 -5 ☔ View full report in Codecov by Sentry. |
zirain
previously approved these changes
Aug 19, 2024
|
cc @liorokman I think that this is already covered by |
guydc
approved these changes
Aug 20, 2024
|
/retest |
|
Nothing is using this structure, it can be safely removed. |
arkodg
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
BackendTrafficPolicyConnectionis a redundant struct.