Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ResolvedRefs HTTPRoute Status Condition Calculation #507

Closed
wants to merge 2 commits into from

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 5, 2022

Updates ProcessHTTPRoutes() to check the availability of all route backends, e.g. Services, and sets the RouteConditionResolvedRefs condition accodingly.

Requires #495

Fixes #415

@danehans danehans requested a review from a team as a code owner October 5, 2022 17:58
@danehans danehans added the area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. label Oct 5, 2022
@danehans danehans added this to the 0.2.0 milestone Oct 5, 2022
@arkodg
Copy link
Contributor

arkodg commented Oct 5, 2022

@danehans a similar status calculation needs to be done for all other status conditions as well and not just RouteConditionResolvedRefs . The core issue here is that the translator only appends conditions and never clears them.
suggest considering an approach outlined in #415 (comment)

Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Copy link
Contributor Author

danehans commented Oct 8, 2022

Closed in favor of #516.

@danehans danehans closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPRoute Status Not Updated After Adding Backend
2 participants